LGTM
https://codereview.chromium.org/1177053006/diff/1/src/ast.h
File src/ast.h (right):
https://codereview.chromium.org/1177053006/diff/1/src/ast.h#newcode487
src/ast.h:487: bool ignore_completion_values() const { return
ignore_completion_values_; }
Nit: why the plural?
https://codereview.chromium.org/1177053006/diff/1/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1177053006/diff/1/src/parser.cc#newcode3227
src/parser.cc:3227: // { // Nothing inside this block can affect the
normal completion value.
Nit: adjust indentation. Also, the comment seems a bit unclear. Maybe
add s.th like "This is an XY block: ..."
https://codereview.chromium.org/1177053006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
