https://codereview.chromium.org/1177053006/diff/1/src/ast.h
File src/ast.h (right):

https://codereview.chromium.org/1177053006/diff/1/src/ast.h#newcode487
src/ast.h:487: bool ignore_completion_values() const { return
ignore_completion_values_; }
On 2015/06/18 10:53:32, conradw wrote:
On 2015/06/18 05:43:21, rossberg wrote:
> Nit: why the plural?

The idea I had in my head was that the block causes each statement
inside to
have its completion value ignored. This matches the way the rewriter
updates the
value of .return at the level of each individual "base"
ExpressionStatement.

The block itself isn't really part of the structure of the program
like a normal
block is, since it's neither part of a production nor associated with
a scope,
so I thought it would be misleading to talk about the block's
"completion
value".

Well, I would argue that's an implementation detail of the rewriter, not
a description of the meaning of the block as such. (Imagine there was no
rewriter, and we compiled these blocks directly.)

https://codereview.chromium.org/1177053006/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to