LGTM with nits.
https://codereview.chromium.org/1177043012/diff/60001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/1177043012/diff/60001/src/objects.cc#newcode12555
src/objects.cc:12555: :
Handle<Object>::cast(isolate->factory()->the_hole_value());
nit: do you even need the cast?
https://codereview.chromium.org/1177043012/diff/60001/src/objects.cc#newcode12570
src/objects.cc:12570: DCHECK(parameter_map->get(1)->IsDictionary());
Since this is something that callers must ensure, maybe move the DCHECK
to the beginning of the function (near
"DCHECK(object->HasSloppyArgumentsElements());")?
https://codereview.chromium.org/1177043012/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
