Patch set 7 still LGTM.
https://codereview.chromium.org/1177043012/diff/100001/src/lookup.cc
File src/lookup.cc (right):
https://codereview.chromium.org/1177043012/diff/100001/src/lookup.cc#newcode185
src/lookup.cc:185: JSObject::SetSloppyArgumentsElement(holder, index(),
value, attributes);
Arguably this should be called SetDictionaryArgumentsElement now... but
IIUC you're planning further refactorings anyway, so that can wait.
https://codereview.chromium.org/1177043012/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
