Guys, thanks a lot for fixing this!
-- Vitaly On Mon, Jan 18, 2010 at 7:07 PM, <[email protected]> wrote: > On 2010/01/18 15:47:51, Erik Corry wrote: >> >> Just one thing: > >> http://codereview.chromium.org/551062/diff/1/7 >> File src/serialize.cc (right): > >> http://codereview.chromium.org/551062/diff/1/7#newcode700 >> src/serialize.cc:700: LOG(SnapshotPositionEvent(address, > > source_->position())); >> >> Putting this in an if (FLAG_log_snapshot_positions) would avoid the call, >> but > > if >> >> you can't see the difference in benchmarks I guess it's not necessary. > > Fixed to be on a safe side. > > > As for Python version: those records are only emitted by a request (when > flag is > specified), so if one still uses Python version, he just should not set this > flag. > > http://codereview.chromium.org/551062 >
-- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
