Yeah, node.js developers will love this.
[+rossberg] Andreas, do the import/export statements (look at codemap.js
for an
example) conflict with official ECMAScript module plans? Once we enable this
support, people will get mad if we break it again, even temporarily.
Style issues:
- Keep two empty new lines between top-level things (specifically, between
the
import/export statements and the rest of the file).
- Comments should begin with an uppercase and end with appropriate
punctuation.
A few more nits and one major comment below:
https://codereview.chromium.org/1179173009/diff/60001/tools/profile.js
File tools/profile.js (left):
https://codereview.chromium.org/1179173009/diff/60001/tools/profile.js#oldcode402
tools/profile.js:402:
keep this line
https://codereview.chromium.org/1179173009/diff/60001/tools/tickprocessor.js
File tools/tickprocessor.js (left):
https://codereview.chromium.org/1179173009/diff/60001/tools/tickprocessor.js#oldcode33
tools/tickprocessor.js:33:
keep this line
https://codereview.chromium.org/1179173009/diff/60001/tools/tickprocessor.js
File tools/tickprocessor.js (right):
https://codereview.chromium.org/1179173009/diff/60001/tools/tickprocessor.js#newcode39
tools/tickprocessor.js:39: return require('child_process').execSync(name
+ ' ' + args.join(' ')).toString();
80-col
https://codereview.chromium.org/1179173009/diff/60001/tools/tickprocessor.js#newcode328
tools/tickprocessor.js:328: this.processLogChunk(contents);
Nope, this is not equivalent. processLogLine has extra logic in it.
https://codereview.chromium.org/1179173009/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
