Reviewers: Jakob, Michael Achenbach, rossberg, noordhuis,
https://codereview.chromium.org/1179173009/diff/60001/tools/profile.js
File tools/profile.js (left):
https://codereview.chromium.org/1179173009/diff/60001/tools/profile.js#oldcode402
tools/profile.js:402:
On 2015/06/19 09:43:53, Jakob wrote:
keep this line
Done.
https://codereview.chromium.org/1179173009/diff/60001/tools/tickprocessor.js
File tools/tickprocessor.js (left):
https://codereview.chromium.org/1179173009/diff/60001/tools/tickprocessor.js#oldcode33
tools/tickprocessor.js:33:
On 2015/06/19 09:43:53, Jakob wrote:
keep this line
Done.
https://codereview.chromium.org/1179173009/diff/60001/tools/tickprocessor.js
File tools/tickprocessor.js (right):
https://codereview.chromium.org/1179173009/diff/60001/tools/tickprocessor.js#newcode39
tools/tickprocessor.js:39: return require('child_process').execSync(name
+ ' ' + args.join(' ')).toString();
On 2015/06/19 09:43:53, Jakob wrote:
80-col
Done.
https://codereview.chromium.org/1179173009/diff/60001/tools/tickprocessor.js#newcode39
tools/tickprocessor.js:39: return require('child_process').execSync(name
+ ' ' + args.join(' ')).toString();
On 2015/06/19 10:43:07, noordhuis wrote:
I suggest using `execFileSync(name, args, { encoding: 'utf8'})` here.
Done.
https://codereview.chromium.org/1179173009/diff/60001/tools/tickprocessor.js#newcode328
tools/tickprocessor.js:328: this.processLogChunk(contents);
On 2015/06/19 09:43:53, Jakob wrote:
Nope, this is not equivalent. processLogLine has extra logic in it.
Done.
Description:
Add support for running the profiler output processing scripts with node.
Currently, using the v8 profiler with node requires fetching v8
dependencies and
building natively inside the node installation. This change allows the
processing scripts to be fall back to node if a d8 installation cannot be
found.
It maintains compatibility with d8 if d8 can be found.
This is an experiment. It would be great to make these tools more
accessible to
node developers.
Please review this at https://codereview.chromium.org/1179173009/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+122, -14 lines):
M tools/SourceMap.js
M tools/codemap.js
M tools/consarray.js
M tools/csvparser.js
M tools/linux-tick-processor
M tools/logreader.js
M tools/profile.js
M tools/profile_view.js
M tools/splaytree.js
M tools/tickprocessor.js
M tools/tickprocessor-driver.js
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
