On 2015/06/19 18:49:05, arv wrote:
https://codereview.chromium.org/1168643005/diff/320001/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/1168643005/diff/320001/src/preparser.h#newcode2936
src/preparser.h:2936: rhs_flags, needs_destructuring, &rhs_classifier,
CHECK_OK);
Don't we need to pass in a new boolean here? The outer needs_destructuring
should not be updated here.
var x, y, z;
[x] = y = z
y does not need_destructuring
var x, y, z;
x = [y] = z
x does not need_destructuring
I thought about this --- My thinking was that it made more sense to just
rewrite
the entire chain of expressions if destructuring is used anywhere in them,
instead of only each individual part involving destructuring. But I could be
sold either way on it
https://codereview.chromium.org/1168643005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
