On 2015/06/22 07:53:43, Sven Panne wrote:
DBC
https://codereview.chromium.org/1201783003/diff/1/src/scanner.cc
File src/scanner.cc (right):
https://codereview.chromium.org/1201783003/diff/1/src/scanner.cc#newcode1436
src/scanner.cc:1436: bool Scanner::ContainsDot() {
Instead of using caveman-style loops, the right way to implement this is
to
make
Scanner/LiteralBuffer obey the iterator protocol. With that, everything is
more
flexible and ContainsDot would be a one-liner with std::find, so it's
probably
not even worth having as a separate function.
That sounds like a refactoring that would make sense in a different CL,
separate
from the functionality introduced here.
https://codereview.chromium.org/1201783003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
