LGTM, mostly nits.
https://codereview.chromium.org/1201783003/diff/40001/src/ast-value-factory.h
File src/ast-value-factory.h (right):
https://codereview.chromium.org/1201783003/diff/40001/src/ast-value-factory.h#newcode148
src/ast-value-factory.h:148: bool ContainsDot() const { return type_ ==
NUMBER_WITH_DOT; }
Nit: IsFloating perhaps?
https://codereview.chromium.org/1201783003/diff/40001/src/ast-value-factory.h#newcode160
src/ast-value-factory.h:160: return smi_;
Nit: keep layout consistent
https://codereview.chromium.org/1201783003/diff/40001/src/ast-value-factory.h#newcode193
src/ast-value-factory.h:193: NUMBER_WITH_DOT,
Nit: can we call this FLOATING?
https://codereview.chromium.org/1201783003/diff/40001/src/ast-value-factory.h#newcode218
src/ast-value-factory.h:218: void MarkWithDot() {
Get rid of this method and add an is_float flag parameter to the
AstValue(double) constructor instead.
https://codereview.chromium.org/1201783003/diff/40001/src/ast-value-factory.h#newcode344
src/ast-value-factory.h:344: const AstValue* NewNumber(double number,
bool with_dot = false);
Nit: is_float?
https://codereview.chromium.org/1201783003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
