https://codereview.chromium.org/1205173002/diff/20001/src/compiler/greedy-allocator.h
File src/compiler/greedy-allocator.h (right):
https://codereview.chromium.org/1205173002/diff/20001/src/compiler/greedy-allocator.h#newcode68
src/compiler/greedy-allocator.h:68: void InitializeAllocations();
Why not just name the method after what it does? InsertFixedRanges()?
https://codereview.chromium.org/1205173002/diff/20001/src/compiler/greedy-allocator.h#newcode72
src/compiler/greedy-allocator.h:72: void InitializeScheduler();
Same here.
https://codereview.chromium.org/1205173002/diff/20001/src/compiler/greedy-allocator.h#newcode76
src/compiler/greedy-allocator.h:76: void
HandleRangesDefinedByMemoryOperand();
"handle" is too general. Please name the method after what it does. This
doesn't return anything, so it obviously has some side effects.
https://codereview.chromium.org/1205173002/diff/20001/src/compiler/greedy-allocator.h#newcode78
src/compiler/greedy-allocator.h:78: void ProcessCandidate(const
AllocationCandidate& candidate);
What does Process mean?
https://codereview.chromium.org/1205173002/diff/20001/src/compiler/greedy-allocator.h#newcode86
src/compiler/greedy-allocator.h:86: float
GetCandidateRangeWeight(LiveRange* range, unsigned size);
Even though this is camel case (and thus CouldPerformCalculations), it
might be better to avoid naming things with the Get prefix if they
compute something.
https://codereview.chromium.org/1205173002/diff/20001/src/compiler/greedy-allocator.h#newcode93
src/compiler/greedy-allocator.h:93: bool HandleSpillOperands(LiveRange*
range);
Again, no idea what "Handle" means here.
https://codereview.chromium.org/1205173002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
