https://codereview.chromium.org/1205173002/diff/20001/src/compiler/coalesced-live-ranges.h
File src/compiler/coalesced-live-ranges.h (right):
https://codereview.chromium.org/1205173002/diff/20001/src/compiler/coalesced-live-ranges.h#newcode16
src/compiler/coalesced-live-ranges.h:16: // TODO(mtrofin): we may be
calculating the weight multiple times. Consider
I'd prefer to have it on the LiveRange instead. This utility class
doesn't seem to make things easier for now.
https://codereview.chromium.org/1205173002/diff/20001/src/compiler/greedy-allocator.h
File src/compiler/greedy-allocator.h (right):
https://codereview.chromium.org/1205173002/diff/20001/src/compiler/greedy-allocator.h#newcode25
src/compiler/greedy-allocator.h:25: }
Nit: Please add an appropriate operator> if you decide to overload
operator<, even if it's currently unused.
https://codereview.chromium.org/1205173002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
