Perhaps we can use the opportunity to clean up the disassembler and
simulator to
use more meaningful names for the bit fields. Page A7-24 and A7-26 have
overviews of the encodings of the VFP instructions. Perhaps we could use
that
to get rid of most of the bit(x, y) = z stuff.
http://codereview.chromium.org/545155/diff/1/4
File src/arm/disasm-arm.cc (right):
http://codereview.chromium.org/545155/diff/1/4#newcode1006
src/arm/disasm-arm.cc:1006: if (instr->Bit(23) == 1) {
This looks wrong to me. Bit 23 can be either 1 or 0 for a vldr
instruction according to the manual.
http://codereview.chromium.org/545155/diff/1/4#newcode1018
src/arm/disasm-arm.cc:1018: if ((instr->Bits(27, 24) == 0xC) &&
This seems silly. Most of these bits are already determined by the fact
that it's a type6 instruction.
http://codereview.chromium.org/545155
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
