LGTM
http://codereview.chromium.org/545155/diff/6001/6003 File src/arm/assembler-arm.cc (right): http://codereview.chromium.org/545155/diff/6001/6003#newcode1376 src/arm/assembler-arm.cc:1376: int offset, I feel strongly that the offset should be byte oriented as it is for other load instructions. With an assert that says it is divisble by 4. http://codereview.chromium.org/545155/diff/6001/6005 File src/arm/simulator-arm.cc (right): http://codereview.chromium.org/545155/diff/6001/6005#newcode2079 src/arm/simulator-arm.cc:2079: #ifdef BIG_ENDIAN_FLOATING_POINT I don't think vfp and big endian floating point exist together except perhaps on big endian ARM. But V8 doesn't support big endian ARM. http://codereview.chromium.org/545155 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
