LGTM
http://codereview.chromium.org/555049/diff/1/4 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/555049/diff/1/4#newcode8185 src/x64/codegen-x64.cc:8185: if (!ascii) { ASSERT(kShortSize == 2); http://codereview.chromium.org/555049/diff/1/4#newcode8197 src/x64/codegen-x64.cc:8197: __ repmovsl(); It is not better to use repmovsq? http://codereview.chromium.org/555049/diff/1/4#newcode8233 src/x64/codegen-x64.cc:8233: const int kStringOffset = 3 * kPointerSize; Now that you have these constants, why not add const int kArgumentsSize = kStringOffset and use that in the __ ret(3 * kPointerSize) below? http://codereview.chromium.org/555049/diff/1/4#newcode8279 src/x64/codegen-x64.cc:8279: __ lea(rsi, Operand(rsi, smi_as_index.reg, smi_as_index.scale, Perhaps use FieldOperand, and remove " - kHeapObjectTag"? http://codereview.chromium.org/555049/diff/1/4#newcode8314 src/x64/codegen-x64.cc:8314: __ lea(rsi, Operand(rsi, smi_as_index.reg, smi_as_index.scale, Operand -> FieldOperand? http://codereview.chromium.org/555049 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
