http://codereview.chromium.org/555049/diff/1/4 File src/x64/codegen-x64.cc (right):
http://codereview.chromium.org/555049/diff/1/4#newcode8185 src/x64/codegen-x64.cc:8185: if (!ascii) { It's not really the size of short ints that matter, but the size of UC16 (or really, the size of characters in SequentialTwoByteString, which kindof gives itself :) I'll add sizeof test for uc16. http://codereview.chromium.org/555049/diff/1/4#newcode8197 src/x64/codegen-x64.cc:8197: __ repmovsl(); Probably, since we expect long strings, the tine spent one having the secondary loop be 0-7 characters instead of 0-3 should be saved on the first loop. http://codereview.chromium.org/555049/diff/1/4#newcode8233 src/x64/codegen-x64.cc:8233: const int kStringOffset = 3 * kPointerSize; Done. http://codereview.chromium.org/555049 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
