On 2015/06/30 12:27:03, rossberg wrote:
LGTM
On 2015/06/29 18:20:13, adamk wrote:
> I'm not sure the debugger stuff can wait, I wouldn't want to ship a
thing
that
> showed an extra phantom variable in devtools.
I'm fine with that. Correctness trumps devtools user experience. If we can
still
fix devtools, we should try, though.
> Andreas, any thoughts on me adding some sort of new VariableMode that's
lexical
> but internal?
Sounds plausible, but may be a substantial amount of work.
Instead of having two different sorts of internal variables we could
perhaps
make all of them lexical, and just make sure that we allocate the
relevant in
the current DeclarationScope (where VAR goes) explicitly. That would
avoid any
need to distinguish them downstream?
Just learned how this actually works, and it's crazy:
https://code.google.com/p/chromium/codesearch#chromium/src/v8/src/scopeinfo.cc&l=431
it's just based on starting with '.'!
So I could fix this by putting a bit on variables in ScopeInfo...
https://codereview.chromium.org/1218543003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
