First round. Really nice cleanup, already looking good. Just a few minor
comments (so far).
https://codereview.chromium.org/1218863002/diff/180001/src/heap/cleanup-gc.cc
File src/heap/cleanup-gc.cc (right):
https://codereview.chromium.org/1218863002/diff/180001/src/heap/cleanup-gc.cc#newcode132
src/heap/cleanup-gc.cc:132: void CleanupGC::ScheduleTimer(double
delay_ms) {
Can we DCHECK that delay_ms is always positive.
https://codereview.chromium.org/1218863002/diff/180001/src/heap/cleanup-gc.cc#newcode137
src/heap/cleanup-gc.cc:137: isolate, new CleanupGC::TimerTask(this),
(delay_ms + kSlackMs) / 1000.0);
where is the delete?
https://codereview.chromium.org/1218863002/diff/180001/src/heap/cleanup-gc.h
File src/heap/cleanup-gc.h (right):
https://codereview.chromium.org/1218863002/diff/180001/src/heap/cleanup-gc.h#newcode17
src/heap/cleanup-gc.h:17: // The goal of the CleanupGC class is to
detect transition of the mutator
Hmm... I am not a big fan of the name CleanupGC. What about
MemoryController? I am open to other alternatives...
https://codereview.chromium.org/1218863002/diff/180001/src/heap/gc-idle-time-handler.cc
File src/heap/gc-idle-time-handler.cc (right):
https://codereview.chromium.org/1218863002/diff/180001/src/heap/gc-idle-time-handler.cc#newcode211
src/heap/gc-idle-time-handler.cc:211: // (2) If the context disposal
rate is high and we cannot perform a full GC,
please update this comment
https://codereview.chromium.org/1218863002/diff/180001/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/1218863002/diff/180001/src/heap/heap.cc#newcode4883
src/heap/heap.cc:4883: CollectAllGarbage(kReduceMemoryFootprintMask,
Could this call end an ongoing incremental marking cycle?
https://codereview.chromium.org/1218863002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
