LGTM, if memory and latency did not regression. Super nice cleanup! Just a
few
nits left.
https://codereview.chromium.org/1218863002/diff/240001/BUILD.gn
File BUILD.gn (right):
https://codereview.chromium.org/1218863002/diff/240001/BUILD.gn#newcode832
BUILD.gn:832: "src/heap/memory-reducer.cc",
alphabetic order
https://codereview.chromium.org/1218863002/diff/240001/src/heap/memory-reducer.cc
File src/heap/memory-reducer.cc (right):
https://codereview.chromium.org/1218863002/diff/240001/src/heap/memory-reducer.cc#newcode1
src/heap/memory-reducer.cc:1: // Copyright 2014 the V8 project authors.
All rights reserved.
2015
https://codereview.chromium.org/1218863002/diff/240001/src/heap/memory-reducer.cc#newcode41
src/heap/memory-reducer.cc:41: PrintIsolate(heap()->isolate(), "Clean-up
GC: started #%d\n",
Please don't use the term Cleanup-gc, also below.
https://codereview.chromium.org/1218863002/diff/240001/src/heap/memory-reducer.h
File src/heap/memory-reducer.h (right):
https://codereview.chromium.org/1218863002/diff/240001/src/heap/memory-reducer.h#newcode1
src/heap/memory-reducer.h:1: // Copyright 2014 the V8 project authors.
All rights reserved.
2015
https://codereview.chromium.org/1218863002/diff/240001/src/heap/memory-reducer.h#newcode72
src/heap/memory-reducer.h:72: explicit State(Action action, int
started_gcs, double next_gc_start_ms)
I think the code style says that this should be a method called
Initialize.
https://codereview.chromium.org/1218863002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
