LGTM.
http://codereview.chromium.org/555098/diff/1/2 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/555098/diff/1/2#newcode7122 src/ia32/codegen-ia32.cc:7122: __ mov(edi, Operand(eax)); // backup the 1st operand No need for Operand: __ mov(edi, eax). Comment should be formatted like a sentence: Backup the left operand. http://codereview.chromium.org/555098/diff/1/2#newcode7277 src/ia32/codegen-ia32.cc:7277: FloatingPointHelper::ARGS_IN_REGISTERS); Does LoadSse2Smis need the ArgLocation argument any more? It now expects them in registers at all call sites. http://codereview.chromium.org/555098 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
