lgtm with suggestions:
https://codereview.chromium.org/1218813012/diff/60001/src/elements.cc
File src/elements.cc (right):
https://codereview.chromium.org/1218813012/diff/60001/src/elements.cc#newcode1002
src/elements.cc:1002: if (obj->elements() != *store) {
It looks like you can do the same trick to unify AddImpl() for
DictionaryElementsAccessor and SlowSloppyArgumentsElementsAccessor.
Or even better if you split the addition/deletion into parts - update
the elements dictionary and then set it into the object.
https://codereview.chromium.org/1218813012/diff/60001/src/elements.cc#newcode1010
src/elements.cc:1010: virtual void Delete(Handle<JSObject> obj, uint32_t
index) final {
Could you please move this virtual Delete() implementation to
ElementsAccessorBase class and in all the successors replace virtual
Delete() with static DeleteImpl()? Like we do for virtual Get()/static
GetImpl() and etc. Just to be uniform.
https://codereview.chromium.org/1218813012/diff/60001/src/lookup.cc
File src/lookup.cc (right):
https://codereview.chromium.org/1218813012/diff/60001/src/lookup.cc#newcode248
src/lookup.cc:248: JSObject::ReoptimizeIfPrototype(holder);
Shouldn't you call NotFound() here?
https://codereview.chromium.org/1218813012/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
