On 2015/07/06 at 06:23:27, binji wrote:
https://codereview.chromium.org/1215233004/diff/40001/src/d8.cc
File src/d8.cc (right):
https://codereview.chromium.org/1215233004/diff/40001/src/d8.cc#newcode1542
src/d8.cc:1542: if (contents.Data()) {
On 2015/07/06 at 05:04:19, jarin wrote:
> On 2015/07/03 14:29:37, jochen wrote:
> > how can data ever be null?
>
> As the comment above says, ReadArrayBufferContents can set the contents
to
empty (line 1600). No?
Yes, that's correct.
if the current approach leaks memory, lsan bots will be unhappy, so we'll
have
to fix that soonish.
anyway, lgtm
https://codereview.chromium.org/1215233004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
