On 2015/07/06 at 07:02:30, jarin wrote:
On 2015/07/06 06:34:47, binji wrote:
> > if the current approach leaks memory, lsan bots will be unhappy, so
we'll
have
> to fix that soonish.
>
> Well, AFAIK it doesn't leak memory. It just doesn't free the SAB memory
until
> the d8 shell is destroyed, rather than when there are no remaining
references to
> the SAB.
What I mean is that the SABs will be only collected when the shell
terminates.
So if you create lot of short-lived SABs you can run out of memory even
though
the live memory is small. No?
Yes, you're right. But those aren't the types of leaks that will be found by
lsan (it only does a leak check at program exit), so we shouldn't have to
worry
about those bots.
https://codereview.chromium.org/1215233004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
