https://codereview.chromium.org/1222843004/diff/20001/src/compiler/ast-graph-builder.cc
File src/compiler/ast-graph-builder.cc (right):
https://codereview.chromium.org/1222843004/diff/20001/src/compiler/ast-graph-builder.cc#newcode2839
src/compiler/ast-graph-builder.cc:2839: Node* value =
BuildThrowUnsupportedSuperError(expr->id());
Shouldn't this be UNREACHABLE? We are supposed to handle all of these at
a higher level.
https://codereview.chromium.org/1222843004/diff/20001/src/compiler/ast-graph-builder.cc#newcode2845
src/compiler/ast-graph-builder.cc:2845: Node* value =
BuildThrowUnsupportedSuperError(expr->id());
Same here. I don't see how these errors can ever be observed?
https://codereview.chromium.org/1222843004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.