LGTM
https://codereview.chromium.org/1222843004/diff/20001/src/compiler/ast-graph-builder.cc
File src/compiler/ast-graph-builder.cc (right):
https://codereview.chromium.org/1222843004/diff/20001/src/compiler/ast-graph-builder.cc#newcode2839
src/compiler/ast-graph-builder.cc:2839: Node* value =
BuildThrowUnsupportedSuperError(expr->id());
On 2015/07/07 15:59:58, Michael Starzinger wrote:
On 2015/07/07 15:48:09, arv wrote:
> Shouldn't this be UNREACHABLE? We are supposed to handle all of
these at a
> higher level.
Yeah, I though so too. Please admire patch set #1 and the associated
failures of
the try job.
I see.
This one comes from
delete (super.prop)
and it looks like we do need to keek the throw here.
https://codereview.chromium.org/1222843004/diff/20001/src/compiler/ast-graph-builder.cc#newcode2845
src/compiler/ast-graph-builder.cc:2845: Node* value =
BuildThrowUnsupportedSuperError(expr->id());
On 2015/07/07 15:59:58, Michael Starzinger wrote:
On 2015/07/07 15:48:09, arv wrote:
> Same here. I don't see how these errors can ever be observed?
Likewise.
This one on the other hand I don't think we can get to.
I'll make the change locally and see what might break.
https://codereview.chromium.org/1222843004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
