PTAL
I'm not yet sure what is going on with eval. It creates a DYNAMIC_LOCAL.
I'm sure there are a million edge cases related to eval that are not
covered in
these tests since these are just the strict mode tests but I thought it was
a
good milestone.
https://codereview.chromium.org/1219853004/diff/20001/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (left):
https://codereview.chromium.org/1219853004/diff/20001/test/cctest/test-parsing.cc#oldcode6778
test/cctest/test-parsing.cc:6778: "const x",
This is not valid in ES'15
https://codereview.chromium.org/1219853004/diff/20001/test/mjsunit/harmony/block-let-semantics-sloppy.js
File test/mjsunit/harmony/block-let-semantics-sloppy.js (right):
https://codereview.chromium.org/1219853004/diff/20001/test/mjsunit/harmony/block-let-semantics-sloppy.js#newcode98
test/mjsunit/harmony/block-let-semantics-sloppy.js:98: //
TestAll('function f() { eval("var y = 2;"); x = 1; }; f(); let x;');
There is something going on with eval scopes here...
https://codereview.chromium.org/1219853004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
