LGTM modulo comments.
I'm not too happy with duplicating all the tests via copy & paste, but I see
that some would probably be difficult to parameterise.
https://codereview.chromium.org/1219853004/diff/40001/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):
https://codereview.chromium.org/1219853004/diff/40001/test/cctest/test-parsing.cc#newcode6787
test/cctest/test-parsing.cc:6787: static const ParserFlag always_flags[]
= {kNoLegacyConst};
It seems a bit weird to run the LegacyConst test with NoLegacyConst, in
particular when it requires removing one (currently valid) legacy const
test.
Can you create a separate ConstSloppy test instead?
https://codereview.chromium.org/1219853004/diff/40001/test/mjsunit/harmony/block-leave-sloppy.js
File test/mjsunit/harmony/block-leave-sloppy.js (left):
https://codereview.chromium.org/1219853004/diff/40001/test/mjsunit/harmony/block-leave-sloppy.js#oldcode178
test/mjsunit/harmony/block-leave-sloppy.js:178: // from with.
Not your change, but I just noticed this comment and don't understand
what 'with' it is talking about. Probably means 'eval'?
https://codereview.chromium.org/1219853004/diff/40001/test/mjsunit/harmony/block-let-semantics-sloppy.js
File test/mjsunit/harmony/block-let-semantics-sloppy.js (right):
https://codereview.chromium.org/1219853004/diff/40001/test/mjsunit/harmony/block-let-semantics-sloppy.js#newcode98
test/mjsunit/harmony/block-let-semantics-sloppy.js:98: //
TestAll('function f() { eval("var y = 2;"); x = 1; }; f(); let x;');
Can you add a TODO explaining why this is commented out right now? And
file a bug, too, so it doesn't get lost.
https://codereview.chromium.org/1219853004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
