https://codereview.chromium.org/1219063017/diff/120001/test/unittests/compiler/coalesced-live-ranges-unittest.cc
File test/unittests/compiler/coalesced-live-ranges-unittest.cc (right):
https://codereview.chromium.org/1219063017/diff/120001/test/unittests/compiler/coalesced-live-ranges-unittest.cc#newcode24
test/unittests/compiler/coalesced-live-ranges-unittest.cc:24:
TestRangeBuilder& operator()(int start, int end) {
Operator overloading is strongly discouraged. Please just use an Add
method for that.
https://codereview.chromium.org/1219063017/diff/120001/test/unittests/compiler/coalesced-live-ranges-unittest.cc#newcode28
test/unittests/compiler/coalesced-live-ranges-unittest.cc:28: operator
LiveRange*() {
How about a Build method instead?
https://codereview.chromium.org/1219063017/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
