lgtm
https://codereview.chromium.org/1238743002/diff/100001/src/compiler/ast-graph-builder.cc
File src/compiler/ast-graph-builder.cc (right):
https://codereview.chromium.org/1238743002/diff/100001/src/compiler/ast-graph-builder.cc#newcode3288
src/compiler/ast-graph-builder.cc:3288: Node*
AstGraphBuilder::BuildHoleCheckElseThrow(Node* value, Variable*
variable,
Nit: Can't you share the impls of these functions? They only need to
differ in their choice of equality operator (=== vs !===).
https://codereview.chromium.org/1238743002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
