https://codereview.chromium.org/1238743002/diff/100001/src/compiler/ast-graph-builder.cc
File src/compiler/ast-graph-builder.cc (right):
https://codereview.chromium.org/1238743002/diff/100001/src/compiler/ast-graph-builder.cc#newcode3288
src/compiler/ast-graph-builder.cc:3288: Node*
AstGraphBuilder::BuildHoleCheckElseThrow(Node* value, Variable*
variable,
On 2015/07/16 07:55:18, Michael Starzinger wrote:
On 2015/07/15 15:00:41, rossberg wrote:
> Nit: Can't you share the impls of these functions? They only need to
differ in
> their choice of equality operator (=== vs !===).
Done. I hope this is what you had in mind, I wasn't entirely sure.
Unfortunately I needed to undo this, because Token::NE_STRICT is not
supported by our CompareICs. We always deconstruct (a !=== b) into !(a
=== b) in ParserBase::ParseBinaryExpression in the parser.
https://codereview.chromium.org/1238743002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
