http://codereview.chromium.org/548179/diff/6001/7001 File src/ia32/codegen-ia32.cc (right):
http://codereview.chromium.org/548179/diff/6001/7001#newcode8405 src/ia32/codegen-ia32.cc:8405: #endif On 2010/01/29 08:09:08, Lasse Reichstein wrote:
Perhaps use #else to make all the following code go away if regexp
aren't
native.
Done. http://codereview.chromium.org/548179/diff/6001/7005 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/548179/diff/6001/7005#newcode6654 src/x64/codegen-x64.cc:6654: __ j(greater, &runtime); On 2010/01/29 08:09:08, Lasse Reichstein wrote:
greater -> above
Thanks, fixed in ia32 version as well. http://codereview.chromium.org/548179/diff/6001/7005#newcode6709 src/x64/codegen-x64.cc:6709: __ andb(rbx, Immediate(kStringRepresentationEncodingMask)); On 2010/01/29 08:09:08, Lasse Reichstein wrote:
Do you need the representation bits any more? You know that it's
sequential.
I.e., you can just and with EncodingMask and use the Z flag directly
to branch,
without a compare in between.
The reason is that the jump to label seq_string from above has both encoding and representation in rbx. http://codereview.chromium.org/548179 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
