Will do other ports now.
https://codereview.chromium.org/1239593003/diff/1/src/ia32/builtins-ia32.cc
File src/ia32/builtins-ia32.cc (right):
https://codereview.chromium.org/1239593003/diff/1/src/ia32/builtins-ia32.cc#newcode120
src/ia32/builtins-ia32.cc:120: // Always push a potential allocation
site to preserve a fixed frame size.
On 2015/07/16 14:08:28, Michael Starzinger wrote:
nit: Ideally this behavior will become the default once we turn the
flag on. So
I think it might even be fine to just drop this comment and move the
push into
the block at line 124 without specifically mentioning the allocation
site.
Applies to all architectures.
Done.
https://codereview.chromium.org/1239593003/diff/1/src/ia32/builtins-ia32.cc#newcode256
src/ia32/builtins-ia32.cc:256: __ mov(edx, Operand(esp, 3 *
kPointerSize));
On 2015/07/16 14:08:28, Michael Starzinger wrote:
Nice catch!
Acknowledged.
https://codereview.chromium.org/1239593003/diff/1/src/ia32/builtins-ia32.cc#newcode428
src/ia32/builtins-ia32.cc:428: // Always push a potential allocation
site to preserve a fixed frame size.
On 2015/07/16 14:08:28, Michael Starzinger wrote:
Likewise.
Done.
https://codereview.chromium.org/1239593003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
