General note: You only get coverage for anything that is guarded by
emit_debug_code(), like the assertion in AssertUndefinedOrAllocationSite,
when
you use debug mode. The test driver will pass --debug-code (which is also
required) for you.
https://codereview.chromium.org/1239593003/diff/60001/src/arm/builtins-arm.cc
File src/arm/builtins-arm.cc (right):
https://codereview.chromium.org/1239593003/diff/60001/src/arm/builtins-arm.cc#newcode477
src/arm/builtins-arm.cc:477: __ AssertUndefinedOrAllocationSite(r6, r4);
This will clobber r4, which contains the untagged JSObject at this
point, you should be able to use r0 here.
https://codereview.chromium.org/1239593003/diff/60001/src/mips64/builtins-mips64.cc
File src/mips64/builtins-mips64.cc (right):
https://codereview.chromium.org/1239593003/diff/60001/src/mips64/builtins-mips64.cc#newcode341
src/mips64/builtins-mips64.cc:341: __ push(a2);
Multiple pushes seem to be going on here, I think this line is bogus.
https://codereview.chromium.org/1239593003/diff/60001/src/mips64/builtins-mips64.cc#newcode477
src/mips64/builtins-mips64.cc:477: __
AssertUndefinedOrAllocationSite(t3, t0);
This will clobber t0, which contains the untagged JSObject at this
point, you should be able to use a0 here.
https://codereview.chromium.org/1239593003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
