On 2015/07/16 22:15:32, Toon Verwaest wrote:
https://codereview.chromium.org/1238593003/diff/40001/src/array.js
File src/array.js (right):
https://codereview.chromium.org/1238593003/diff/40001/src/array.js#newcode637
src/array.js:637: } else if (%_HasFastPackedElements(array)) {
On 2015/07/16 22:08:13, adamk wrote:
> This needs an IS_ARRAY check (you can cache this above). Please add a
test
> covering this. This object violates the contract PackedArrayReverse() is
> expecting:
>
> { length: 2, 0: 'foo', __proto__: { get 1() { delete this[1] } } }
>
> Arrays can't have this problem because of their exotic 'length'.
Do we have objects with packed elements that are not arrays?
I'm guessing you are saying the answer is no? You're the expert on elements
transitions :)
https://codereview.chromium.org/1238593003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
