https://codereview.chromium.org/1238593003/diff/40001/src/array.js
File src/array.js (left):
https://codereview.chromium.org/1238593003/diff/40001/src/array.js#oldcode571
src/array.js:571: if (!IS_UNDEFINED(current_i) || low in array) {
On 2015/07/16 22:08:13, adamk wrote:
As discussed offline, I don't think SparseReverse needs to be changed
at all,
since it's guaranteed that [[Get]] and [[HasProperty]] are both
side-effect free
in here.
Done.
https://codereview.chromium.org/1238593003/diff/40001/src/array.js
File src/array.js (right):
https://codereview.chromium.org/1238593003/diff/40001/src/array.js#newcode637
src/array.js:637: } else if (%_HasFastPackedElements(array)) {
On 2015/07/16 22:08:13, adamk wrote:
This needs an IS_ARRAY check (you can cache this above). Please add a
test
covering this. This object violates the contract PackedArrayReverse()
is
expecting:
{ length: 2, 0: 'foo', __proto__: { get 1() { delete this[1] } } }
Arrays can't have this problem because of their exotic 'length'.
Done.
https://codereview.chromium.org/1238593003/diff/40001/src/array.js#newcode640
src/array.js:640: return InnerArrayReverse(array, len);
On 2015/07/16 22:08:13, adamk wrote:
how about "GenericArrayReverse" as the name for this instead?
Done.
https://codereview.chromium.org/1238593003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
