LGTM
http://codereview.chromium.org/549207/diff/1/6 File src/parser.cc (right): http://codereview.chromium.org/549207/diff/1/6#newcode212 src/parser.cc:212: bool* is_simple_out, Remove the _out prefix on these out params? http://codereview.chromium.org/549207/diff/1/6#newcode218 src/parser.cc:218: bool* is_simple_out, Remove _out on these as well? http://codereview.chromium.org/549207/diff/1/6#newcode3955 src/parser.cc:3955: void Parser::BuildObjectLiteralConstantProperties( This is used for normal parsing of object literals as well, right? Move before the JSON comment? http://codereview.chromium.org/549207/diff/1/7 File src/parser.h (right): http://codereview.chromium.org/549207/diff/1/7#newcode137 src/parser.h:137: bool is_json = false); Can we use the validation state enum here instead to make calls to MakeAST easier to read? http://codereview.chromium.org/549207/diff/1/9 File src/scanner.h (right): http://codereview.chromium.org/549207/diff/1/9#newcode424 src/scanner.h:424: Token::Value ScanJsonNumber(); For each of these Scan functions, please add a comment explaining (at least some of the ways in which) JSON scanning differs from JavaScript scanning. Also, there are probably spec references that would make sense to add here for quick reference. http://codereview.chromium.org/549207 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
