http://codereview.chromium.org/549207/diff/1/6
File src/parser.cc (right):

http://codereview.chromium.org/549207/diff/1/6#newcode212
src/parser.cc:212: bool* is_simple_out,
Done.

http://codereview.chromium.org/549207/diff/1/6#newcode218
src/parser.cc:218: bool* is_simple_out,
Done, too.

http://codereview.chromium.org/549207/diff/1/6#newcode3955
src/parser.cc:3955: void Parser::BuildObjectLiteralConstantProperties(
Done.

http://codereview.chromium.org/549207/diff/1/8
File src/scanner.cc (right):

http://codereview.chromium.org/549207/diff/1/8#newcode692
src/scanner.cc:692: if (c0_ < '0' || c0_ > '9') return Token::ILLEGAL;
This code does allow a zero digit after the "e".
As for sense ... I guess you can't rule it out in automatically
generated code JSON.

In retrospect, I should probably have used an IsDigit predicate for
readablity.

http://codereview.chromium.org/549207

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to