https://codereview.chromium.org/1238143002/diff/20001/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (right):

https://codereview.chromium.org/1238143002/diff/20001/src/x64/code-stubs-x64.cc#newcode5169
src/x64/code-stubs-x64.cc:5169: __ j(equal, &fast_case);
On 2015/07/19 20:29:29, Igor Sheludko wrote:
I think it is better to write field and RecordWriteField(...,
OMIT_SMI_CHECK)
here instead of jumping to fast case that does a smi check in
RecordWriteField()
again.

Even better idea: we could add an explicit smi check before the above
RecordWriteField(), which we can then call as RecordWriteField(...,
OMIT_SMI_CHECK) and jump there from here after storing to the cell.

https://codereview.chromium.org/1238143002/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to