A few questions that came up whilst working on the ARM port. These probably
apply to the other ports too.
https://codereview.chromium.org/1238143002/diff/20001/src/ia32/full-codegen-ia32.cc
File src/ia32/full-codegen-ia32.cc (right):
https://codereview.chromium.org/1238143002/diff/20001/src/ia32/full-codegen-ia32.cc#newcode1414
src/ia32/full-codegen-ia32.cc:1414: __
Move(LoadGlobalViaContextDescriptor::SlotRegister(), Immediate(slot));
Is it safe to pass raw (non-smi) integers to stubs? Can't CallStub
trigger a GC?
https://codereview.chromium.org/1238143002/diff/20001/src/ia32/full-codegen-ia32.cc#newcode2693
src/ia32/full-codegen-ia32.cc:2693: int const slot = var->index() + 1;
`slot` shadows a function argument.
https://codereview.chromium.org/1238143002/diff/20001/src/ia32/full-codegen-ia32.cc#newcode2694
src/ia32/full-codegen-ia32.cc:2694: int const depth =
scope()->ContextChainLength(var->scope());
Also, isn't the preferred style "const int" in Google V8?
https://codereview.chromium.org/1238143002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
