lgtm.
Even though it would be even better if
- all the DCHECKs took into account the new flag.
- the flag was explicitly passed on the HAdd constructor (ideally as an
enum,
with the default value being the normal add) and then DCHECK that the
representations are in sync with the constructor flag. I just want to avoid
the
situation that somebody uses the dangerous HAdd by accident.
https://codereview.chromium.org/1244693002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
