looks good with one final nit
https://codereview.chromium.org/1244693002/diff/120001/src/mips/lithium-mips.cc
File src/mips/lithium-mips.cc (right):
https://codereview.chromium.org/1244693002/diff/120001/src/mips/lithium-mips.cc#newcode1625
src/mips/lithium-mips.cc:1625:
DCHECK(instr->left()->representation().IsExternal());
You can leave out DCHECK(instr->left()->representation().IsExternal()),
it is covered by IsConsistentExternalRepresentation.
https://codereview.chromium.org/1244693002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
