still lgtm
https://codereview.chromium.org/1242333002/diff/80001/src/frames.cc
File src/frames.cc (right):
https://codereview.chromium.org/1242333002/diff/80001/src/frames.cc#newcode1449
src/frames.cc:1449: DCHECK(page->owner() == heap->code_space());
DCHECK_EQ?
https://codereview.chromium.org/1242333002/diff/80001/src/frames.cc#newcode1451
src/frames.cc:1451: page, reinterpret_cast<PagedSpace*>(page->owner()));
you always invoke this method with page, page->owner(). why not just
pass only page, and compute owner internally?
https://codereview.chromium.org/1242333002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
