Reviewers: jochen,
https://codereview.chromium.org/1242333002/diff/80001/src/frames.cc
File src/frames.cc (right):
https://codereview.chromium.org/1242333002/diff/80001/src/frames.cc#newcode1449
src/frames.cc:1449: DCHECK(page->owner() == heap->code_space());
On 2015/07/27 14:53:05, jochen wrote:
DCHECK_EQ?
Done.
https://codereview.chromium.org/1242333002/diff/80001/src/frames.cc#newcode1451
src/frames.cc:1451: page, reinterpret_cast<PagedSpace*>(page->owner()));
On 2015/07/27 14:53:05, jochen wrote:
you always invoke this method with page, page->owner(). why not just
pass only
page, and compute owner internally?
Done.
Description:
Reland concurrent sweeping of code space.
BUG=
Please review this at https://codereview.chromium.org/1242333002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+93, -38 lines):
M src/frames.cc
M src/heap/heap.cc
M src/heap/mark-compact.h
M src/heap/mark-compact.cc
M src/heap/spaces.cc
M src/heap/store-buffer.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
