Missing comment.
https://codereview.chromium.org/1257543003/diff/40001/src/interpreter/bytecodes.cc
File src/interpreter/bytecodes.cc (right):
https://codereview.chromium.org/1257543003/diff/40001/src/interpreter/bytecodes.cc#newcode19
src/interpreter/bytecodes.cc:19: { __VA_ARGS__ } \
On 2015/07/27 14:56:57, rmcilroy (OOO until 10th Aug) wrote:
Does C++ always zero-initialize entries in an array? i.e., does:
{ Operand::kImm8 }
turn into
{ 1, 0, 0 }
here implicitly, or are entries [1] and [2] undefined?
Yes, C++ will initialize these to zero provided at least one value is
given. For readability the declarations could include kNone as the last
operand type or use templates to pad out the arguments to explicitly
include 0's.
The current nit that grates here is counting the operands at runtime
rather than compile time. The current pattern is more readable, but
would be better to determine at compile time.
https://codereview.chromium.org/1257543003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
