This change lgtm, but as noted below it looks a little brittle. Is there no
way
to better-encapsulate the incrementing logic in the PreParserFormalParameter
base class?
https://codereview.chromium.org/1259013003/diff/1/src/parser.h
File src/parser.h (right):
https://codereview.chromium.org/1259013003/diff/1/src/parser.h#newcode559
src/parser.h:559: DCHECK(arity == params.length());
DCHECK_EQ.
Also, it will probably be more clear after the followup, but it seems
sad that the only way to check this consistency is a DCHECK. Especially
since the incrementing code is now duplicated between preparser and
parser.
https://codereview.chromium.org/1259013003/diff/1/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/1259013003/diff/1/src/preparser.h#newcode3673
src/preparser.h:3673: DCHECK(parameters->arity == 0);
DCHECK_EQ
https://codereview.chromium.org/1259013003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
