https://codereview.chromium.org/1259013003/diff/1/src/parser.h
File src/parser.h (right):
https://codereview.chromium.org/1259013003/diff/1/src/parser.h#newcode559
src/parser.h:559: DCHECK(arity == params.length());
On 2015/08/03 18:20:23, adamk wrote:
DCHECK_EQ.
Done.
Also, it will probably be more clear after the followup, but it seems
sad that
the only way to check this consistency is a DCHECK. Especially since
the
incrementing code is now duplicated between preparser and parser.
My thinking was that the parser/preparser duplication should go away
eventually, once statement parsing is unified. But the FormalParameter
will stay separate. So you want to move as little of the logic there as
possible.
But maybe you are right, I'll reconsider in the follow-up CL.
https://codereview.chromium.org/1259013003/diff/1/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/1259013003/diff/1/src/preparser.h#newcode3673
src/preparser.h:3673: DCHECK(parameters->arity == 0);
On 2015/08/03 18:20:23, adamk wrote:
DCHECK_EQ
Done.
https://codereview.chromium.org/1259013003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
