lgtm
https://codereview.chromium.org/1273483002/diff/1/src/heap/incremental-marking.h
File src/heap/incremental-marking.h (right):
https://codereview.chromium.org/1273483002/diff/1/src/heap/incremental-marking.h#newcode31
src/heap/incremental-marking.h:31: CompletionAction complete_action_ =
NO_GC_VIA_STACK_GUARD,
For readability of the call site, I would prefer passing flags
explicitly in the main constructor and making static constructor
function with descriptive name for specific flag combinations that are
frequently used.
https://codereview.chromium.org/1273483002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
