https://codereview.chromium.org/1273483002/diff/60001/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/1273483002/diff/60001/src/heap/heap.cc#newcode4806
src/heap/heap.cc:4806: GCIdleTimeHandler::HeapState heap_state =
ComputeHeapState();
You don't need the heap_state for that. Just call
EstimateMarkingStepSize with incremental marking speed. Also, document
that in the API.
https://codereview.chromium.org/1273483002/diff/60001/src/heap/heap.h
File src/heap/heap.h (right):
https://codereview.chromium.org/1273483002/diff/60001/src/heap/heap.h#newcode855
src/heap/heap.h:855: void StartIncrementalMarking(int gc_flags,
Add comments to these functions.
https://codereview.chromium.org/1273483002/diff/60001/src/heap/incremental-marking.cc
File src/heap/incremental-marking.cc (right):
https://codereview.chromium.org/1273483002/diff/60001/src/heap/incremental-marking.cc#newcode485
src/heap/incremental-marking.cc:485: (reason == nullptr) ? "unknown
reason" : reason);
can we always have a reason?
https://codereview.chromium.org/1273483002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
