https://codereview.chromium.org/1271703002/diff/60001/src/compiler/move-optimizer.cc
File src/compiler/move-optimizer.cc (right):
https://codereview.chromium.org/1271703002/diff/60001/src/compiler/move-optimizer.cc#newcode69
src/compiler/move-optimizer.cc:69: if (has_only_deferred) continue;
On 2015/08/04 20:34:46, Mircea Trofin wrote:
On 2015/08/04 19:39:43, Jarin wrote:
> Could you explain why we skip the optimization here?
This would pull down common fills. If the fills occur in deferred
blocks, and
the closest common successor is not deferred, we lose the optimization
of
spilling/filling just in deferred blocks.
Should have added: the last statement of the MultipleDeferredBlockSpills
unit test (EXPECT_EQ...) would fail without this logic.
https://codereview.chromium.org/1271703002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
