I think I understand now how the spilling works, but it is very subtle.
Once you
add explanatory comments, it will be good to go.
What are the performance numbers?
https://codereview.chromium.org/1271703002/diff/80001/src/compiler/register-allocator.cc
File src/compiler/register-allocator.cc (right):
https://codereview.chromium.org/1271703002/diff/80001/src/compiler/register-allocator.cc#newcode408
src/compiler/register-allocator.cc:408: // the range and control flow
connection mechanism instead.
Please elaborate on how this uses the control flow connection mechanism.
This incremental build-up of various moves is in my opinion the worst
part of the register allocator (in terms of understandability and
maintainability), and this CL makes it worse. It should be explained in
the comments.
https://codereview.chromium.org/1271703002/diff/80001/src/compiler/register-allocator.h
File src/compiler/register-allocator.h (right):
https://codereview.chromium.org/1271703002/diff/80001/src/compiler/register-allocator.h#newcode417
src/compiler/register-allocator.h:417: // in which it may be worse to
spill in it.
The comment seems to be out of date (it refers to the ranges with just
one spilled child).
https://codereview.chromium.org/1271703002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
